Skip to content

Conversation

xeniag
Copy link
Member

@xeniag xeniag commented Sep 9, 2026

Created previous, next and go to favorites buttons

Added "previous", "next", "go to favorites" buttons and a placeholder for CatCard placeholder to see arrow placements.

@xeniag xeniag added the US1 label Sep 9, 2026
@xeniag xeniag self-assigned this Sep 9, 2026
@xeniag xeniag requested a review from a team as a code owner September 9, 2026 12:57
@xeniag xeniag linked an issue Sep 9, 2026 that may be closed by this pull request
Copy link
Member

@anettkva anettkva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice visually, love the hover/focus states on the buttons 🙌

Noticed ActionButtons.tsx exists but doesn't seem to be used in App.tsx, the buttons there are separate inline JSX. Is that still needed, or was it an earlier approach before switching to inline? Just a suggestion, but might be worth keeping App.tsx fairly thin and pulling the buttons (Previous/Next, Favorite) out into their own components and import them?
Happy to help if you want a hand with any of this☺️

Also some small notes:

  • prettier flagged some formatting on both files (indentation + missing newline at end), probably just needs a re-format pass. (I think the prettier pre-commit failed)
  • this should go into dev first, not main:)

@xeniag xeniag changed the base branch from main to dev September 14, 2026 06:47
@xeniag xeniag requested a review from anettkva September 14, 2026 10:29
Copy link
Member

@anettkva anettkva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@ronjalh ronjalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider giving a source for the star svg

@ronjalh ronjalh merged commit 7171152 into dev Sep 14, 2026
@ronjalh ronjalh deleted the 12-feat-add-previousnext-buttons branch September 14, 2026 10:56
@xeniag xeniag linked an issue Sep 16, 2026 that may be closed by this pull request
Sign in to join this conversation on GitHub.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

US1: browse cat pictures
3 participants