-
Notifications
You must be signed in to change notification settings - Fork 0
12 feat add previousnext buttons #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice visually, love the hover/focus states on the buttons 🙌
Noticed ActionButtons.tsx exists but doesn't seem to be used in App.tsx, the buttons there are separate inline JSX. Is that still needed, or was it an earlier approach before switching to inline? Just a suggestion, but might be worth keeping App.tsx fairly thin and pulling the buttons (Previous/Next, Favorite) out into their own components and import them?
Happy to help if you want a hand with any of this
Also some small notes:
- prettier flagged some formatting on both files (indentation + missing newline at end), probably just needs a re-format pass. (I think the prettier pre-commit failed)
- this should go into dev first, not main:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider giving a source for the star svg
Created previous, next and go to favorites buttons
Added "previous", "next", "go to favorites" buttons and a placeholder for
CatCardplaceholder to see arrow placements.